FW: Potential errors in latest header DTDs

[Prasad Yendluri <pyendluri@vitria.com>]

Hi,
 
I am noticing few problems we need to fix in the ebXML-Header DTD. 
I am referring to the latest ebXMLHeader dtd (pkg_0_6fn1.dtd) that Farrukh
sent out.
I have attached that to this message for your reference.
 
1. <!ATTLIST ebXMLHeader  Version     CDATA  #FIXED '1.0'
                       MessageType CDATA  #FIXED 'Normal' >
    This should not be an attribute with fixed value, as this is expeted to
take other values. 
    Additionally this should be a required attribute as a value is needed.
   Also since the valid values are a fixed enumeration (Normal |
Acknowledgement | Error), I 
   suggest, we change it be as follows:
 
                 MessageType  (Normal | Acknowledgement | Error)  #REQUIRED 
    
2. <!ATTLIST Action  Version CDATA    #FIXED '1.0'
                  e-dtype NMTOKEN  #FIXED 'string' >
   Again the version attribute should not be #FIXED. 
   The value depends on the actual version of the Action message. In fact we
are using a value '1.1' in PO Request message for example.
   I suggest we change it to #IMPLIED as follows:
 
   <!ATTLIST Action  Version CDATA  #IMPLIED>

 
3. <!ATTLIST ReliableMessagingInfo  DeliverySemantics  (AtMostOnce |
Unspecified )  #FIXED 'Unspecified' >
    This gives a choice of values to delivery semantics at the same time
fixes the value at 'Unspecified'. 
    I believe, the correct value there is #REQUIRED (without the
'Unspecified' part):
 
    <!ATTLIST ReliableMessagingInfo  DeliverySemantics  (AtMostOnce |
Unspecified ) #REQUIRED>
 
4. We are using the "xmlns" attribute with the element ebXMLHeader. But,
that attribute is not specified in the DTD.
    I believe we need that.
 
     xmlns CDATA #IMPLIED 
 
Comments?
 
I am attaching a new DTD with these fixed (ebXMLHeaderPY.dtd). Please
respond ASAP if you have issues.
 
Thanks, Prasad
  
 
 
-----Original Message-----
From: Farrukh Najmi [mailto:Farrukh.Najmi@east.sun.com] 
Sent: Tuesday, August 01, 2000 10:16 AM
To: chris.ferris@east.sun.com
Cc: ebxml-poc@lists.ebxml.org; ebxml-transport@lists.ebxml.org
Subject: Potential errors in latest header DTDs


  
Hi Chris, 

The following to the best of my knowledge seem to be errors/omission in the
latest header DTD: 


1.	The ebXMLHeader.Manifest element correctly allows multiple
Manifest.DocumentReference sub-elements. However, the
Manifest.DocumentReference can have multiple pairs of DocumentLabel and
DocumentId. This seems incorrect: 
<!ELEMENT Manifest  (DocumentReference )+> 
<!ELEMENT DocumentReference  (DocumentLabel , DocumentId )+> 
 
^^^ 


	It should be: 
<!ELEMENT Manifest  (DocumentReference )+> 
<!ELEMENT DocumentReference  (DocumentLabel , DocumentId )> 
  

2.	Missing attribute Version with default of 1.0 on element Action. I
recall you had planned to include it in an email. 

Since time is running out and you are traveling, I have attached the
original DTD (pkg_0_6.dtd) as well as a modified one (pkg_0_6fn1.dtd) with
the above problems fixed. Please give the poc list a go-no-go on whether to
used the modified DTD I have attached. 

-- 


Regards, 
Farrukh 
  
  
  
  


Here is the diff of the changes. Note my DTD authoring tool may have
reformatted your original somewhat: 


< <!ELEMENT DocumentReference  (DocumentLabel , DocumentId )+> 
--- 
> 
> <!ELEMENT DocumentReference  (DocumentLabel , DocumentId )> 
> 
15c17,18 
< <!ATTLIST Action  e-dtype NMTOKEN  #FIXED 'string' > 
--- 
> <!ATTLIST Action  Version CDATA    #FIXED '1.0' 
>                   e-dtype NMTOKEN  #FIXED 'string' >

pkg_0_6.dtd

pkg_0_6fn1.dtd

begin:vcard 
n:Najmi;Farrukh 
tel;fax:781-442-1610
tel;work:781-442-0703
x-mozilla-html:TRUE
url:www.sun.com
org:Sun Microsystems;Java Software
adr:;;1 Network Drive, MS BUR02-302;Burlington;MA;01803-0902;USA
version:2.1
email;internet:najmi@east.sun.com
fn:Farrukh S. Najmi
end:vcard

ebXMLHeaderPY.dtd